feat: added config for COAT metrics#47520
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 11 commits intomainfrom Apr 1, 2026
Merged
feat: added config for COAT metrics#47520gh-worker-dd-mergequeue-cf854d[bot] merged 11 commits intomainfrom
gh-worker-dd-mergequeue-cf854d[bot] merged 11 commits intomainfrom
Conversation
nlchung
changed the title
github-actions
Bot
added
the
short review
nlchung
added
changelog/no-changelog
Contributor
Files inventory check summaryFile checks results against ancestor 1abe12f9: Results for datadog-agent_7.79.0~devel.git.348.0818fce.pipeline.105452186-1_amd64.deb:No change detected |
Contributor
Static quality checks✅ Please find below the results from static quality gates Error
Gate failure full details
Note: Some gates exceeded limits but are non-blocking because the size hasn't increased from the ancestor commit. Successful checksInfo
21 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: de7acb4 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +0.93 | [-2.06, +3.92] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +0.93 | [-2.06, +3.92] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.61 | [+0.56, +0.66] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.52 | [+0.48, +0.55] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_logs | % cpu utilization | +0.39 | [-1.26, +2.04] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.36 | [+0.19, +0.53] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | +0.36 | [+0.29, +0.43] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.29 | [+0.15, +0.43] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.19 | [+0.13, +0.25] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.08 | [-0.45, +0.60] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.06 | [-0.17, +0.28] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.05 | [-0.33, +0.43] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.03 | [-0.03, +0.09] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.03 | [-0.13, +0.19] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.03 | [-0.40, +0.46] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.00 | [-0.20, +0.20] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.20, +0.20] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.11, +0.11] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.01 | [-0.19, +0.17] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.02 | [-0.07, +0.04] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.03 | [-0.11, +0.04] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.32 | [-0.46, -0.18] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | -0.33 | [-0.56, -0.09] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_logs | memory utilization | -0.44 | [-0.54, -0.35] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 731 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 273.80MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 706 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.23GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.20GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.22GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 174.38MiB ≤ 175MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 492.05MiB ≤ 550MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 204.61MiB ≤ 220MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 346.63 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 423.04MiB ≤ 475MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 522078e632
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c9b1aad402
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
github-actions
Bot
added
medium review
nlchung
added
need-change/agenttelemetry-governance
iglendd
approved these changes
Mar 31, 2026
louis-cqrl
approved these changes
Apr 1, 2026
Sophie-Ruetschi
pushed a commit
that referenced
this pull request
Apr 3, 2026
### What does this PR do? Adds some DCA metrics to the cluster-agent COAT profile in `defaultProfiles`, enabling fleet-wide visibility into Container Platform feature adoption and health. Each metric is configured with `aggregate_tags` to retain only low-cardinality categorical tags; high-cardinality customer-specific tags (namespace, node name, workload name) are intentionally excluded. Metrics added: - Admission Webhooks: `mutation_attempts`, `library_injection_attempts`, `library_injection_errors`, `patcher_errors`, `rc_provider_configs`, `rc_provider_configs_invalid` - Autodiscovery: `errors`, `watched_resources` - Cluster Checks: `configs_dispatched`, `configs_dangling`, `unscheduled_check` - External Metrics: `datadog_metrics` - Language Detection: `language_detection_patcher.patches` - WorkloadMeta / Tagger: `stored_entities` (both), `pull_errors` ### Motivation See [engineering brief](https://datadoghq.atlassian.net/wiki/spaces/CONTP/pages/6294275581/Container+Features+Metrics+in+Cross-Org+Agent+Telemetry) and [CONTP-1260](https://datadoghq.atlassian.net/browse/CONTP-1260) ### Describe how you validated your changes - Verified all metrics are already exposed as Prometheus metrics by the DCA — no new instrumentation added - Verified aggregate_tags include only bounded, categorical tags with low per-host context counts per 15-minute window - Tag selection reviewed against COAT cardinality guidelines ### Additional Notes [CONTP-1260]: https://datadoghq.atlassian.net/browse/CONTP-1260?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: nicole.chung <nicole.chung@datadoghq.com>
gh-worker-dd-mergequeue-cf854d Bot
pushed a commit
that referenced
this pull request
Apr 16, 2026
…ofile (#49394) ### What does this PR do? - Adds `cluster_checks.configs_info` to the COAT cluster-agent profile with only the `check_name` aggregate tag - Enables visibility into which integration types (e.g. postgres, mysql, http_check) are dispatched as cluster checks - Excludes high-cardinality tags (`check_id`, `node`, `join_leader`) to keep contexts bounded (~10-30 per host) Updated [engineering brief](https://datadoghq.atlassian.net/wiki/spaces/CONTP/pages/6294275581/Container+Features+Metrics+in+Cross-Org+Agent+Telemetry) to align with this change. An addition to recently added cluster agent COAT metrics added in PR #47520 ### Motivation [CONTP-1601](https://datadoghq.atlassian.net/browse/CONTP-1601) Dashboard feedback requested insight into the most commonly dispatched cluster check integration types. ### Describe how you validated your changes - Unit tests pass (`dda inv test --targets=./comp/core/agenttelemetry/impl/...` — 40/40) - Will verify metric appears in COAT telemetry payload on a cluster with dispatched checks [CONTP-1601]: https://datadoghq.atlassian.net/browse/CONTP-1601?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ ### Additional Notes Co-authored-by: nicole.chung <nicole.chung@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds some DCA metrics to the cluster-agent COAT profile in
defaultProfiles, enabling fleet-wide visibility into Container Platform feature adoption and health. Each metric is configured withaggregate_tagsto retain only low-cardinality categorical tags; high-cardinality customer-specific tags (namespace, node name, workload name) are intentionally excluded.Metrics added:
mutation_attempts,library_injection_attempts,library_injection_errors,patcher_errors,rc_provider_configs,rc_provider_configs_invaliderrors,watched_resourcesconfigs_dispatched,configs_dangling,unscheduled_checkdatadog_metricslanguage_detection_patcher.patchesstored_entities(both),pull_errorsMotivation
See engineering brief and CONTP-1260
Describe how you validated your changes
Additional Notes